feat: add toBePressed matcher (#203) #658
Merged
+212
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, may I ask for reviews? |
|
Hi @gnapse, can I kindly ask for a review? |
gnapse
requested changes
Aug 11, 2025
kretajak
force-pushed
the
feat/add-to-be-pressed-matcher
branch
from
5a89af4 to
2662e5d
Compare
gnapse
approved these changes
Aug 13, 2025
|
@all-contributors please add @kretajak for code, test |
|
I've put up a pull request to add @kretajak! 🎉 |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
New
toBePressedmatcher is addedWhy:
Closes #203
Checklist:
In my opinion this PR could be followed by another one which would add support for checking
aria-pressed="mixed". MaybetoBePartiallyPressed? It would follow the same approach as splittertoBeCheckedandtoBePartiallyCheckedinto two separate matchers.